Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbaJQLMN (ORCPT ); Fri, 17 Oct 2014 07:12:13 -0400 Received: from smtp1.it.da.ut.ee ([193.40.5.66]:54601 "EHLO smtp1.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbaJQLML (ORCPT ); Fri, 17 Oct 2014 07:12:11 -0400 Date: Fri, 17 Oct 2014 14:12:09 +0300 (EEST) From: Meelis Roos To: David Miller cc: iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, sparclinux@vger.kernel.org Subject: Re: unaligned accesses in SLAB etc. In-Reply-To: <20141016.165017.1151349565275102498.davem@davemloft.net> Message-ID: References: <20141016.160742.1639247937393238792.davem@redhat.com> <20141016.162001.599580415052560455.davem@redhat.com> <20141016.165017.1151349565275102498.davem@davemloft.net> User-Agent: Alpine 2.11 (LRH 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: David Miller > Date: Thu, 16 Oct 2014 16:20:01 -0400 (EDT) > > > So I'm going to audit all the code paths to make sure we don't put garbage > > into the fault_code value. > > There are two code paths where we can put garbage into the fault_code > value. And for the dtlb_prot.S case, the value we put in there is > TLB_TAG_ACCESS which is 0x30, which include bit 0x20 which is that > FAULT_CODE_BAD_RA indication which is erroneously triggering. > > The other path is via hugepage TLB misses, for the situation where > we haven't allocated the huge TSB for the thread yet. That might > explain some other longer-term problems we've had. > > I'm about to test the following fix: Thank you - it seems to work fine for me on E3500 on top of 3.17.0-07551-g052db7e + slab alignment fix. However, on top of mainline HEAD 3.17.0-09670-g0429fbc it explodes with scheduler BUG - just reported to LKML + sched maintainers. -- Meelis Roos (mroos@linux.ee) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/