Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbaJQNML (ORCPT ); Fri, 17 Oct 2014 09:12:11 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:47640 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbaJQNMJ (ORCPT ); Fri, 17 Oct 2014 09:12:09 -0400 Date: Fri, 17 Oct 2014 14:12:00 +0100 From: Mark Rutland To: Chunyan Zhang , Arnd Bergmann Cc: Catalin Marinas , "gregkh@linuxfoundation.org" , "ijc+devicetree@hellion.org.uk" , "jslaby@suse.cz" , "galak@codeaurora.org" , "broonie@linaro.org" , "m-karicheri2@ti.com" , Pawel Moll , "artagnon@gmail.com" , "rrichter@cavium.com" , "robh+dt@kernel.org" , Will Deacon , "orsonzhai@gmail.com" , "geng.ren@spreadtrum.com" , "zhizhou.zhang@spreadtrum.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "sprdlinux@freelists.org" Subject: Re: [PATCH v2 1/5] Documentation: DT: Renamed of-serial.txt to 8250.txt Message-ID: <20141017131200.GD5587@leverpostej> References: <1413539665-11484-1-git-send-email-chunyan.zhang@spreadtrum.com> <1413539665-11484-2-git-send-email-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413539665-11484-2-git-send-email-chunyan.zhang@spreadtrum.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [adding Arnd to Cc, as this was his suggestion] On Fri, Oct 17, 2014 at 10:54:21AM +0100, Chunyan Zhang wrote: > The file of-serial.txt was only for 8250 compatible UART implementations, > so renamed it to 8250.txt to avoid confusing other persons. > > Signed-off-by: Chunyan Zhang This makes sense to me, so: Acked-by: Mark Rutland In future please use git format-patch -C -M when moving things around. It should detect that this is a rename and generate a trivial diff, rather than featuring every line of the file twice. Thanks, Mark. > --- > Documentation/devicetree/bindings/serial/8250.txt | 50 ++++++++++++++++++++ > .../devicetree/bindings/serial/of-serial.txt | 50 -------------------- > 2 files changed, 50 insertions(+), 50 deletions(-) > create mode 100644 Documentation/devicetree/bindings/serial/8250.txt > delete mode 100644 Documentation/devicetree/bindings/serial/of-serial.txt > > diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt > new file mode 100644 > index 0000000..7705477 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/8250.txt > @@ -0,0 +1,50 @@ > +* UART (Universal Asynchronous Receiver/Transmitter) > + > +Required properties: > +- compatible : one of: > + - "ns8250" > + - "ns16450" > + - "ns16550a" > + - "ns16550" > + - "ns16750" > + - "ns16850" > + - "nvidia,tegra20-uart" > + - "nxp,lpc3220-uart" > + - "ibm,qpace-nwp-serial" > + - "altr,16550-FIFO32" > + - "altr,16550-FIFO64" > + - "altr,16550-FIFO128" > + - "serial" if the port type is unknown. > +- reg : offset and length of the register set for the device. > +- interrupts : should contain uart interrupt. > +- clock-frequency : the input clock frequency for the UART > + or > + clocks phandle to refer to the clk used as per Documentation/devicetree > + /bindings/clock/clock-bindings.txt > + > +Optional properties: > +- current-speed : the current active speed of the UART. > +- reg-offset : offset to apply to the mapbase from the start of the registers. > +- reg-shift : quantity to shift the register offsets by. > +- reg-io-width : the size (in bytes) of the IO accesses that should be > + performed on the device. There are some systems that require 32-bit > + accesses to the UART (e.g. TI davinci). > +- used-by-rtas : set to indicate that the port is in use by the OpenFirmware > + RTAS and should not be registered. > +- no-loopback-test: set to indicate that the port does not implements loopback > + test mode > +- fifo-size: the fifo size of the UART. > +- auto-flow-control: one way to enable automatic flow control support. The > + driver is allowed to detect support for the capability even without this > + property. > +- has-hw-flow-control: the hardware has flow control capability. > + > +Example: > + > + uart@80230000 { > + compatible = "ns8250"; > + reg = <0x80230000 0x100>; > + clock-frequency = <3686400>; > + interrupts = <10>; > + reg-shift = <2>; > + }; > diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt > deleted file mode 100644 > index 7705477..0000000 > --- a/Documentation/devicetree/bindings/serial/of-serial.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -* UART (Universal Asynchronous Receiver/Transmitter) > - > -Required properties: > -- compatible : one of: > - - "ns8250" > - - "ns16450" > - - "ns16550a" > - - "ns16550" > - - "ns16750" > - - "ns16850" > - - "nvidia,tegra20-uart" > - - "nxp,lpc3220-uart" > - - "ibm,qpace-nwp-serial" > - - "altr,16550-FIFO32" > - - "altr,16550-FIFO64" > - - "altr,16550-FIFO128" > - - "serial" if the port type is unknown. > -- reg : offset and length of the register set for the device. > -- interrupts : should contain uart interrupt. > -- clock-frequency : the input clock frequency for the UART > - or > - clocks phandle to refer to the clk used as per Documentation/devicetree > - /bindings/clock/clock-bindings.txt > - > -Optional properties: > -- current-speed : the current active speed of the UART. > -- reg-offset : offset to apply to the mapbase from the start of the registers. > -- reg-shift : quantity to shift the register offsets by. > -- reg-io-width : the size (in bytes) of the IO accesses that should be > - performed on the device. There are some systems that require 32-bit > - accesses to the UART (e.g. TI davinci). > -- used-by-rtas : set to indicate that the port is in use by the OpenFirmware > - RTAS and should not be registered. > -- no-loopback-test: set to indicate that the port does not implements loopback > - test mode > -- fifo-size: the fifo size of the UART. > -- auto-flow-control: one way to enable automatic flow control support. The > - driver is allowed to detect support for the capability even without this > - property. > -- has-hw-flow-control: the hardware has flow control capability. > - > -Example: > - > - uart@80230000 { > - compatible = "ns8250"; > - reg = <0x80230000 0x100>; > - clock-frequency = <3686400>; > - interrupts = <10>; > - reg-shift = <2>; > - }; > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/