Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751533AbaJRSia (ORCPT ); Sat, 18 Oct 2014 14:38:30 -0400 Received: from mail-vc0-f178.google.com ([209.85.220.178]:55585 "EHLO mail-vc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbaJRSi3 (ORCPT ); Sat, 18 Oct 2014 14:38:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140930191933.GC5011@tucsk.piliscsaba.szeredi.hu> <542BE551.1010705@parallels.com> <543F9E75.2090509@parallels.com> <20141017085509.GE5011@tucsk.piliscsaba.szeredi.hu> Date: Sat, 18 Oct 2014 11:38:28 -0700 X-Google-Sender-Auth: 1wW3sAE89TX-VJulo3bJsfjKCXY Message-ID: Subject: Re: [PATCH 0/5] fuse: handle release synchronously (v4) From: Linus Torvalds To: Miklos Szeredi Cc: Maxim Patlasov , Anand Avati , Linux Kernel Mailing List , Michael j Theall , fuse-devel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 18, 2014 at 11:01 AM, Miklos Szeredi wrote: > > And what you don't get is that there's a deep difference between those > and the /proc file access case. No there isn't. Your "action by the holder" argument is pure and utter garbage, for a very simple and core reason: the *filesystem* doesn't know or care. So from a fuse standpoint, the difference is totally and entirely irrelevant. Your "synchronous fput" fails. It fails totally regardless of that "who incremented the file user count" issue. Face it, your patch is broken. And it's *fundamentally* broken, which is why I'm so tired of your stupid ad-hoc hacks that cannot possibly work. Your umount EBUSY case is somewhat relevant to the "who holds the file open", but quite frankly, that's not a filesystem issue, it's more of a system management issue. So umount might get EBUSY. That's not something the filesystem should/could care about, that's a MIS issue that is entirely irrelevant, and the answer is "if somebody does lsof, that might keep the filesystem busy". Tough. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/