Message-ID: <1413765718.7076.3.camel@perches.com>
Subject: Re: [PATCH 1/2] binfmt_misc: add comments & debug logs
From: Joe Perches <joe@perches.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Date: Sun, 19 Oct 2014 17:41:58 -0700
In-Reply-To: <1413759826-11958-1-git-send-email-vapier@gentoo.org>
References: <1413759826-11958-1-git-send-email-vapier@gentoo.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-10-19 at 19:03 -0400, Mike Frysinger wrote:
> let's deploy extensive pr_debug markers at
> logical parse points, and add comments to the dense parsing logic.
[]
> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
[]
> @@ -259,14 +270,17 @@ static char * check_special_flags (char * sfs, Node * e)
>  	while (cont) {
>  		switch (*p) {
>  			case 'P':
> +				pr_debug("register: flag: P (preserve argv0)");

Missing '\n' newline.
Can you please add them as appropriate?

>  				p++;
>  				e->flags |= MISC_FMT_PRESERVE_ARGV0;
>  				break;
>  			case 'O':
> +				pr_debug("register: flag: O (open binary)");

etc...

> @@ -292,6 +306,8 @@ static Node *create_entry(const char __user *buffer, size_t count)
>  	char *buf, *p;
>  	char del;
>  
> +	pr_debug("register: received %zu bytes", count);

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/