Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420AbaJTFJB (ORCPT ); Mon, 20 Oct 2014 01:09:01 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:62665 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbaJTFI7 (ORCPT ); Mon, 20 Oct 2014 01:08:59 -0400 MIME-Version: 1.0 In-Reply-To: <1413384491-23703-4-git-send-email-octavian.purdila@intel.com> References: <1413384491-23703-1-git-send-email-octavian.purdila@intel.com> <1413384491-23703-4-git-send-email-octavian.purdila@intel.com> From: Alexandre Courbot Date: Mon, 20 Oct 2014 14:08:38 +0900 Message-ID: Subject: Re: [PATCH v8 3/4] gpiolib: add irq_not_threaded flag to gpio_chip To: Octavian Purdila Cc: Greg Kroah-Hartman , Linus Walleij , Wolfram Sang , Samuel Ortiz , Lee Jones , Arnd Bergmann , Johan Hovold , daniel.baluta@intel.com, laurentiu.palcu@intel.com, "linux-usb@vger.kernel.org" , Linux Kernel Mailing List , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 15, 2014 at 11:48 PM, Octavian Purdila wrote: > Some GPIO chips (e.g. the DLN2 USB adapter) have blocking get/set > operation but do not need a threaded irq handler. Sorry if you already explained this (I have been a little bit late with the GPIO reviews recently), but does this optimization bring a significant benefit that justifies adding another field in struct gpio_chip? If so it would be nice to have it in the commit message. If not, do we need this at all? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/