Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbaJTLi0 (ORCPT ); Mon, 20 Oct 2014 07:38:26 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:39774 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbaJTLiZ (ORCPT ); Mon, 20 Oct 2014 07:38:25 -0400 From: Chen Weixiang X-Google-Original-From: Chen Weixiang Date: Mon, 20 Oct 2014 19:38:19 +0800 To: Konrad Zapalowicz Cc: Chen Weixiang , Marek Belisko , Greg Kroah-Hartman , Greg Donald , Chen Gang , Artem Fetishev , Andrey Utkin , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] staging: ft1000: space required after that ',' Message-ID: <20141020113819.GA8743@chenwx> Mail-Followup-To: Konrad Zapalowicz , Chen Weixiang , Marek Belisko , Greg Kroah-Hartman , Greg Donald , Chen Gang , Artem Fetishev , Andrey Utkin , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1413723590-19690-1-git-send-email-weixiang.chen@gmail.com> <1413723590-19690-4-git-send-email-weixiang.chen@gmail.com> <20141019132700.GA3632@t400> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141019132700.GA3632@t400> User-Agent: Mutt/1.5.23 (b8a63730c848) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 19, 2014 at 03:27:00PM +0200, Konrad Zapalowicz wrote: > On 10/19, Chen Weixiang wrote: > > - u8 ConnectionMsg[] = {0x00,0x44,0x10,0x20,0x80,0x00,0x00,0x00,0x00,0x00,0x03,0x00,0x00,0x00,0x93,0x64, > > - 0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x05,0x00,0x00,0x00,0x0a, > > - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, > > - 0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x12,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00, > > - 0x00,0x00,0x02,0x37,0x00,0x00,0x00,0x08,0x00,0x00,0x00,0x01,0x00,0x01,0x7f,0x00, > > - 0x00,0x01,0x00,0x00}; > > + u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64, > > + 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00, > > + 0x00, 0x01, 0x00, 0x00}; > > Nice, however it still violates the 80 characters a line rule. Please > redo this patch. > Thanks, > Konrad > OK, I'll re-organize the array ConnectionMsg[], check the patches with checkpatch and send the patches again. Thank you, Konrad. -- Best regards, Chen Weixiang (Alex) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/