From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Michal Simek <michal.simek@xilinx.com>,
        Josh Cartwright <josh.cartwright@ni.com>, monstr@monstr.eu,
        Russell King <linux@arm.linux.org.uk>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        linux-kernel@vger.kernel.org,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH v2 1/3] ARM: zynq: Move common.h to generic location
Date: Mon, 20 Oct 2014 15:36:06 +0200
Message-ID: <3225036.9QQDRKvzZS@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <742a19eb987f3f99b42ba4b7e7ebc27bf19d7d72.1413811526.git.michal.simek@xilinx.com>
References: <742a19eb987f3f99b42ba4b7e7ebc27bf19d7d72.1413811526.git.michal.simek@xilinx.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org

On Monday 20 October 2014 15:25:31 Michal Simek wrote:
> include/soc/zynq/ is the right location for this header
> to be able to share information from this header with other
> drivers which require it.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> Changes in v2:
> - Update pm.c added in 3.17 too - Soren pointed on it
> 
>  arch/arm/mach-zynq/common.c                       |  2 +-
>  arch/arm/mach-zynq/hotplug.c                      | 14 --------------
>  arch/arm/mach-zynq/platsmp.c                      |  2 +-
>  arch/arm/mach-zynq/pm.c                           |  2 +-
>  arch/arm/mach-zynq/slcr.c                         |  2 +-
>  {arch/arm/mach-zynq => include/soc/zynq}/common.h |  0
>  6 files changed, 4 insertions(+), 18 deletions(-)
>  delete mode 100644 arch/arm/mach-zynq/hotplug.c
>  rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
> 

NAK

Most (if not all) of that header should not be visible to drivers.
If you need to share some symbols, make a proper header file for those,
not one called 'common.h'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/