Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbaJTS0v (ORCPT ); Mon, 20 Oct 2014 14:26:51 -0400 Received: from exprod5og116.obsmtp.com ([64.18.0.147]:39266 "HELO exprod5og116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751102AbaJTS0t convert rfc822-to-8bit (ORCPT ); Mon, 20 Oct 2014 14:26:49 -0400 X-Greylist: delayed 391 seconds by postgrey-1.27 at vger.kernel.org; Mon, 20 Oct 2014 14:26:49 EDT MIME-Version: 1.0 In-Reply-To: <1413792496-8558-1-git-send-email-geert@linux-m68k.org> References: <1413792496-8558-1-git-send-email-geert@linux-m68k.org> Date: Mon, 20 Oct 2014 11:20:09 -0700 Message-ID: Subject: Re: [PATCH] drivers: net: xgene: Add missing initialization in xgene_enet_ecc_init() From: Iyappan Subramanian To: Geert Uytterhoeven Cc: "David S. Miller" , Keyur Chudgar , netdev , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 20, 2014 at 1:08 AM, Geert Uytterhoeven wrote: > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ‘xgene_enet_ecc_init’: > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ‘data’ may be used uninitialized in this function > > Depending on the arbitrary value on the stack, the loop may terminate > too early, and cause a bogus -ENODEV failure. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c b/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c > index e6d24c2101982444..19e13583b4259cd4 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c > @@ -123,7 +123,7 @@ static u32 xgene_enet_rd_mac(struct xgene_enet_pdata *p, u32 rd_addr) > static int xgene_enet_ecc_init(struct xgene_enet_pdata *p) > { > struct net_device *ndev = p->ndev; > - u32 data; > + u32 data = 0; > int i; > > xgene_enet_wr_diag_csr(p, ENET_CFG_MEM_RAM_SHUTDOWN_ADDR, 0); > -- > 1.9.1 > Acked-by: Iyappan Subramanian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/