Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109AbaJUB2t (ORCPT ); Mon, 20 Oct 2014 21:28:49 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:45096 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbaJUB2r (ORCPT ); Mon, 20 Oct 2014 21:28:47 -0400 MIME-Version: 1.0 In-Reply-To: <1799842.6CvQjvbUTo@wuerfel> References: <1411992293-7729-1-git-send-email-zhang.lyra@gmail.com> <4004425.NZAxCnE0qr@wuerfel> <1799842.6CvQjvbUTo@wuerfel> Date: Tue, 21 Oct 2014 09:28:45 +0800 Message-ID: Subject: Re: [PATCH 2/6] arm64: Add DTS support for Spreadtrum's Shark64 SoC From: Lyra Zhang To: Arnd Bergmann Cc: Catalin Marinas , "gregkh@linuxfoundation.org" , "ijc+devicetree@hellion.org.uk" , "jslaby@suse.cz" , Kumar Gala , Mark Brown , Mark Rutland , "m-karicheri2@ti.com" , Pawel Moll , Ramkumar Ramachandra , "rrichter@cavium.com" , "robh+dt@kernel.org" , Will Deacon , Orson Zhai , "geng.ren@spreadtrum.com" , "zhizhou.zhang" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "chunyan.zhang" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Arnd This problem have been solved, and was submitted in v2. Thanks for your answer to the question(which Orson asked for me) about this on Freenode. Best regards, Lyra 2014-10-21 3:00 GMT+08:00 Arnd Bergmann : > On Wednesday 15 October 2014 11:17:07 Lyra Zhang wrote: >> Hi, Arnd > > Hi Lyra, > > Sorry for the late reply, I've been away travelling and am just > now catching up on email. Have you found a solution or do > you still need help with this? > > Arnd > >> 2014-09-29 21:47 GMT+08:00 Arnd Bergmann : >> > On Monday 29 September 2014 20:04:49 zhang.lyra@gmail.com wrote: >> >> + >> >> +/memreserve/ 0x80000000 0x00010000; >> > >> > Maybe add a comment explaining why it is reserved? >> > >> >> + chosen { >> >> + bootargs = "earlycon=serial_sprd,0x70000000"; >> >> + }; >> > >> > Just remove this for now, the command line should really be set by the >> > boot loader, not hardcoded in the dts file. >> > >> > IIRC, the earlycon=... syntax is not recommended on DT based systems, >> > better use the "stdout-path" syntax instead. >> > >> >> I have tried to use "stdout-path" instead of "bootargs= "earlycon= >> ..." like below : >> >> / { >> ... >> >> chosen { >> stdout-path = "/serial@70000000"; >> }; >> >> uart0: serial@70000000 { >> status="okay"; >> }; >> ... >> }; >> >> But then there is nothing output information on serial console.(I have >> been testing in Fast Model) >> >> >> I saw the below code in init/main.c >> >> /* Check for early params. */ >> static int __init do_early_param(char *param, char *val, const char *unused) >> { >> const struct obs_kernel_param *p; >> >> for (p = __setup_start; p < __setup_end; p++) { >> if ((p->early && parameq(param, p->str)) || >> (strcmp(param, "console") == 0 && >> strcmp(p->str, "earlycon") == 0) >> ) { >> if (p->setup_func(val) != 0) >> pr_warn("Malformed early option '%s'\n", param); >> } >> } >> /* We accept everything at this stage. */ >> return 0; >> } >> >> And I saw a patch from Grant Likely, he had a comment in it : >> "If the devicetree specifies a serial port as a stdout device, then the >> kernel can use it as the default console if nothing else was selected on >> the command line. For any serial port that uses the uart_add_one_port() >> feature, the uart_add_one_port() has all the information needed to >> automatically enable the console device, which is what this patch does." >> >> So, I guess that the reason why I can't see any output information on >> console after using "stdout-path" instead of "earlycon" is that I >> haven't a driver of Spreadtrum's serial, and dose not use the >> uart_add_one_port() feature. >> >> I don't know is correct what I guess. >> >> Could you give me some suggestions to solve this problem? >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/