Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbaJUECg (ORCPT ); Tue, 21 Oct 2014 00:02:36 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:33432 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbaJUECe (ORCPT ); Tue, 21 Oct 2014 00:02:34 -0400 MIME-Version: 1.0 In-Reply-To: <5445D6F7.1000805@landley.net> References: <20141020144448.59e2e067d632c70353296e56@linux-foundation.org> <5445D6F7.1000805@landley.net> From: Andy Lutomirski Date: Mon, 20 Oct 2014 21:02:02 -0700 Message-ID: Subject: Re: [PATCH] init: Remove CONFIG_INIT_FALLBACK To: Rob Landley Cc: Andrew Morton , Josh Triplett , Frank Rowand , "linux-kernel@vger.kernel.org" , Chuck Ebbert , Randy Dunlap , Shuah Khan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 20, 2014 at 8:45 PM, Rob Landley wrote: > On 10/20/14 17:04, Andy Lutomirski wrote: >> --- a/init/main.c >> +++ b/init/main.c >> @@ -960,13 +960,8 @@ static int __ref kernel_init(void *unused) >> ret = run_init_process(execute_command); >> if (!ret) >> return 0; >> -#ifndef CONFIG_INIT_FALLBACK >> panic("Requested init %s failed (error %d).", >> execute_command, ret); >> -#else >> - pr_err("Failed to execute %s (error %d). Attempting defaults...\n", >> - execute_command, ret); >> -#endif >> } >> if (!try_to_run_init_process("/sbin/init") || >> !try_to_run_init_process("/etc/init") || >> > > Would you like to remove the try_to_run_init_process() stack of random > hardwired names that we can never reach if we panic, or do you just want > to remove the error message? > I'm confused. That code is reachable if there's no initramfs and init= is not specified. --Andy > Confused, > > Rob -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/