Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbaJUJvH (ORCPT ); Tue, 21 Oct 2014 05:51:07 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:40332 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbaJUJvD (ORCPT ); Tue, 21 Oct 2014 05:51:03 -0400 X-Originating-IP: 50.43.41.112 Date: Tue, 21 Oct 2014 02:50:43 -0700 From: Josh Triplett To: Christoph Hellwig Cc: Pieter Smith , Alexander Viro , Andrew Morton , Eric Paris , Matt Turner , Michal Hocko , "Paul E. McKenney" , Fabian Frederick , Tejun Heo , ????????? , "Luis R. Rodriguez" , Peter Foley , Konstantin Khlebnikov , "Eric W. Biederman" , "H. Peter Anvin" , Oleg Nesterov , Andy Lutomirski , David Herrmann , Kees Cook , linux-fsdevel@vger.kernel.org, open list , "open list:ABI/API" Subject: Re: [PATCH 2/2] fs: Support compiling out sendfile Message-ID: <20141021095043.GB18167@thin> References: <1413841728-1313-1-git-send-email-pieter@boesman.nl> <1413841728-1313-2-git-send-email-pieter@boesman.nl> <20141020222421.GE8929@cloud> <20141021075154.GB10020@infradead.org> <20141021090421.GB17604@thin> <20141021091356.GA26330@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141021091356.GA26330@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 21, 2014 at 02:13:56AM -0700, Christoph Hellwig wrote: > On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: > > That's the plan, but since sendfile depends on some of the splice bits, > > sendfile needs to be optional as well; SENDFILE_SYSCALL will then select > > SPLICE_SYSCALLS. > > Just include sendfile with the splice syscalls - we don't really need a > config option for every obscure syscall. No objection here. Pieter, since you're planning to remove splice anyway, can you just fold the two together under the same Kconfig option? That should simplify the patch series, since you won't need to split the two. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/