Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756034AbaJUQSJ (ORCPT ); Tue, 21 Oct 2014 12:18:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755656AbaJUQSG (ORCPT ); Tue, 21 Oct 2014 12:18:06 -0400 Message-ID: <1413908269.4202.135.camel@ul30vt.home> Subject: Re: [PATCH v8 02/18] vfio: platform: probe to devices on the platform bus From: Alex Williamson To: Antonios Motakis Cc: kvmarm@lists.cs.columbia.edu, iommu@lists.linux-foundation.org, will.deacon@arm.com, tech@virtualopensystems.com, christoffer.dall@linaro.org, eric.auger@linaro.org, kim.phillips@freescale.com, marc.zyngier@arm.com, open list , "open list:VFIO DRIVER" , "open list:ABI/API" Date: Tue, 21 Oct 2014 10:17:49 -0600 In-Reply-To: <1413205825-6370-3-git-send-email-a.motakis@virtualopensystems.com> References: <1413205825-6370-1-git-send-email-a.motakis@virtualopensystems.com> <1413205825-6370-3-git-send-email-a.motakis@virtualopensystems.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-10-13 at 15:10 +0200, Antonios Motakis wrote: > Driver to bind to Linux platform devices, and callbacks to discover their > resources to be used by the main VFIO PLATFORM code. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/platform/vfio_platform.c | 107 ++++++++++++++++++++++++++++++++++ > include/uapi/linux/vfio.h | 1 + > 2 files changed, 108 insertions(+) > create mode 100644 drivers/vfio/platform/vfio_platform.c > > diff --git a/drivers/vfio/platform/vfio_platform.c b/drivers/vfio/platform/vfio_platform.c > new file mode 100644 > index 0000000..baeb7da > --- /dev/null > +++ b/drivers/vfio/platform/vfio_platform.c > @@ -0,0 +1,107 @@ > +/* > + * Copyright (C) 2013 - Virtual Open Systems > + * Author: Antonios Motakis > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License, version 2, as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "vfio_platform_private.h" > + > +#define DRIVER_VERSION "0.8" > +#define DRIVER_AUTHOR "Antonios Motakis " > +#define DRIVER_DESC "VFIO for platform devices - User Level meta-driver" > + > +/* probing devices from the linux platform bus */ > + > +static struct resource *get_platform_resource(struct vfio_platform_device *vdev, > + int num) > +{ > + struct platform_device *dev = (struct platform_device *) vdev->opaque; > + int i; > + > + for (i = 0; i < dev->num_resources; i++) { > + struct resource *r = &dev->resource[i]; > + > + if (resource_type(r) & (IORESOURCE_MEM|IORESOURCE_IO)) { > + num--; > + > + if (!num) > + return r; Has this been tested? What happens when we call this with num = 0? > + } > + } > + return NULL; > +} > + > +static int get_platform_irq(struct vfio_platform_device *vdev, int i) > +{ > + struct platform_device *pdev = (struct platform_device *) vdev->opaque; > + > + return platform_get_irq(pdev, i); > +} > + > + > +static int vfio_platform_probe(struct platform_device *pdev) > +{ > + struct vfio_platform_device *vdev; > + int ret; > + > + vdev = kzalloc(sizeof(*vdev), GFP_KERNEL); > + if (!vdev) > + return -ENOMEM; > + > + vdev->opaque = (void *) pdev; > + vdev->name = pdev->name; > + vdev->flags = VFIO_DEVICE_FLAGS_PLATFORM; > + vdev->get_resource = get_platform_resource; > + vdev->get_irq = get_platform_irq; > + > + ret = vfio_platform_probe_common(vdev, &pdev->dev); > + if (ret) > + kfree(vdev); > + > + return ret; > +} > + > +static int vfio_platform_remove(struct platform_device *pdev) > +{ > + return vfio_platform_remove_common(&pdev->dev); > +} > + > +static struct platform_driver vfio_platform_driver = { > + .probe = vfio_platform_probe, > + .remove = vfio_platform_remove, > + .driver = { > + .name = "vfio-platform", > + .owner = THIS_MODULE, > + }, > +}; > + > +module_platform_driver(vfio_platform_driver); > + > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 111b5e8..aca6d3e 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -158,6 +158,7 @@ struct vfio_device_info { > __u32 flags; > #define VFIO_DEVICE_FLAGS_RESET (1 << 0) /* Device supports reset */ > #define VFIO_DEVICE_FLAGS_PCI (1 << 1) /* vfio-pci device */ > +#define VFIO_DEVICE_FLAGS_PLATFORM (1 << 2) /* vfio-platform device */ > __u32 num_regions; /* Max region index + 1 */ > __u32 num_irqs; /* Max IRQ index + 1 */ > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/