Message-ID: <1413909608.12828.5.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Improve warning message for "needless if"
 case
From: Joe Perches <joe@perches.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: festevam@gmail.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Date: Tue, 21 Oct 2014 09:40:08 -0700
In-Reply-To: <1413902024-2932-1-git-send-email-fabio.estevam@freescale.com>
References: <1413902024-2932-1-git-send-email-fabio.estevam@freescale.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-10-21 at 12:33 -0200, Fabio Estevam wrote:
> Break the sentence so that it looks better:
> 
> WARNING: debugfs_remove(NULL) is safe. This check is probably not required
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4446,7 +4446,7 @@ sub process {
>  			my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
>  			if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
>  				WARN('NEEDLESS_IF',
> -				     "$1(NULL) is safe this check is probably not required\n" . $hereprev);
> +				     "$1(NULL) is safe. This check is probably not required\n" . $hereprev);
>  			}
>  		}
>  

Mixing sentences with and without periods is jarring.
I'd prefer a comma or a dash.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/