Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933276AbaJUQoH (ORCPT ); Tue, 21 Oct 2014 12:44:07 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:47415 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932769AbaJUQoF (ORCPT ); Tue, 21 Oct 2014 12:44:05 -0400 MIME-Version: 1.0 In-Reply-To: <1413909608.12828.5.camel@perches.com> References: <1413902024-2932-1-git-send-email-fabio.estevam@freescale.com> <1413909608.12828.5.camel@perches.com> Date: Tue, 21 Oct 2014 14:44:03 -0200 Message-ID: Subject: Re: [PATCH] checkpatch: Improve warning message for "needless if" case From: Fabio Estevam To: Joe Perches Cc: Fabio Estevam , Andrew Morton , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches wrote: > > Mixing sentences with and without periods is jarring. > I'd prefer a comma or a dash. Or what about? "is safe and this check is probably not required" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/