Message-ID: <1413910281.12828.6.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Improve warning message for "needless if"
 case
From: Joe Perches <joe@perches.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date: Tue, 21 Oct 2014 09:51:21 -0700
In-Reply-To: <CAOMZO5BjP=o0EsQJoA_ddYYPGJhY1tUVy6mbA1_tGhd2VUJFEw@mail.gmail.com>
References: <1413902024-2932-1-git-send-email-fabio.estevam@freescale.com>
	 <1413909608.12828.5.camel@perches.com>
	 <CAOMZO5BjP=o0EsQJoA_ddYYPGJhY1tUVy6mbA1_tGhd2VUJFEw@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-10-21 at 14:44 -0200, Fabio Estevam wrote:
> On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches <joe@perches.com> wrote:
> 
> >
> > Mixing sentences with and without periods is jarring.
> > I'd prefer a comma or a dash.
> 
> Or what about?
> 
> "is safe and this check is probably not required"

That'd be fine too

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/