Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933415AbaJUUjV (ORCPT ); Tue, 21 Oct 2014 16:39:21 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:42540 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933065AbaJUUjT (ORCPT ); Tue, 21 Oct 2014 16:39:19 -0400 Date: Tue, 21 Oct 2014 16:39:07 -0400 From: Johannes Weiner To: Kamezawa Hiroyuki Cc: Andrew Morton , Hugh Dickins , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 1/4] mm: memcontrol: uncharge pages on swapout Message-ID: <20141021203907.GA29116@phnom.home.cmpxchg.org> References: <1413818532-11042-1-git-send-email-hannes@cmpxchg.org> <1413818532-11042-2-git-send-email-hannes@cmpxchg.org> <5445B1E8.1010100@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5445B1E8.1010100@jp.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 21, 2014 at 10:07:52AM +0900, Kamezawa Hiroyuki wrote: > (2014/10/21 0:22), Johannes Weiner wrote: > > mem_cgroup_swapout() is called with exclusive access to the page at > > the end of the page's lifetime. Instead of clearing the PCG_MEMSW > > flag and deferring the uncharge, just do it right away. This allows > > follow-up patches to simplify the uncharge code. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/memcontrol.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index bea3fddb3372..7709f17347f3 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -5799,6 +5799,7 @@ static void __init enable_swap_cgroup(void) > > */ > > void mem_cgroup_swapout(struct page *page, swp_entry_t entry) > > { > > + struct mem_cgroup *memcg; > > struct page_cgroup *pc; > > unsigned short oldid; > > > > @@ -5815,13 +5816,21 @@ void mem_cgroup_swapout(struct page *page, swp_entry_t entry) > > return; > > > > VM_BUG_ON_PAGE(!(pc->flags & PCG_MEMSW), page); > shouldn't be removed ? It's still a legitimate check at this point. But it's removed later in the series when PCG_MEMSW itself goes away. > Reviewed-by: KAMEZAWA Hiroyuki Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/