Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933760AbaJUVuL (ORCPT ); Tue, 21 Oct 2014 17:50:11 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58082 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933656AbaJUVuJ (ORCPT ); Tue, 21 Oct 2014 17:50:09 -0400 Date: Tue, 21 Oct 2014 14:50:19 -0700 From: Darren Hart To: Grant Likely Cc: Darren Hart , Mark Rutland , David Woodhouse , "Rafael J. Wysocki" , Linux Kernel Mailing List , Greg Kroah-Hartman , Mika Westerberg , ACPI Devel Maling List , Aaron Lu , "devicetree@vger.kernel.org" , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Arnd Bergmann Subject: Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties? support Message-ID: <20141021215019.GG20951@vmdeb7> References: <2660541.BycO7TFnA2@vostro.rjw.lan> <1413378271.2762.77.camel@infradead.org> <20141015131551.GC20034@leverpostej> <1413379736.2762.79.camel@infradead.org> <20141015134209.GD20034@leverpostej> <543E88CF.5060504@linux.intel.com> <20141015151702.GG20034@leverpostej> <543E9605.6020502@linux.intel.com> <20141018083549.99F1AC408A6@trevor.secretlab.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141018083549.99F1AC408A6@trevor.secretlab.ca> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 18, 2014 at 10:35:49AM +0200, Grant Likely wrote: > On Wed, 15 Oct 2014 17:43:01 +0200 > , Darren Hart > wrote: > > > > > > On 10/15/14 17:17, Mark Rutland wrote: > > > On Wed, Oct 15, 2014 at 03:46:39PM +0100, Darren Hart wrote: > > > > >> Mark, what would you propose we do differently to enable this driver to > > >> be firmware-type agnostic? > > > > > > For this particular driver, all I'm asking for is that the > > > "used-by-rtas" property is not moved over from of_find_property to > > > device_get_property. It is irrelevant for all ACPI systems. Evidently my > > > comment was unclear; I apologise for that. > > > > So my objection here is that by keeping the of_* terms in the driver we > > are required to include of, although it does safely convert to returning > > NULL if !CONFIG_OF I suppose. > > This shouldn't be that controversial. There will be things that only make > sense for DT or only ACPI. Allowing the property to be processed when > the other interface is being used may tempt firmware authors to use the > property because it just happens to have a side effect that looks right > to them. > > I don't see any problem with factoring out those bits into a function > that is only called (or built) when the associated firmware interface is > used. In these situations, the driver isn't 100% generic, so having > small per-firmware hooks is absolutely okay and not a burden to > maintain. Hrm... well, I suppose this isn't a hill I want to die on. I can disagree and commit here :-) -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/