Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754856AbaJVJyT (ORCPT ); Wed, 22 Oct 2014 05:54:19 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:60166 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754745AbaJVJyQ (ORCPT ); Wed, 22 Oct 2014 05:54:16 -0400 X-Google-Original-Sender: Date: Wed, 22 Oct 2014 11:51:12 +0200 From: Johan Hovold To: Greg KH Cc: Philip Munksgaard , johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: serial: Fix indentation style issue Message-ID: <20141022095112.GJ2113@localhost> References: <1413035383-3981-1-git-send-email-pmunksgaard@gmail.com> <20141011142049.GA11456@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141011142049.GA11456@kroah.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > Fix a style issue > > > > Signed-off-by: Philip Munksgaard > > --- > > drivers/usb/serial/option.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > > index d1a3f60..d88998d 100644 > > --- a/drivers/usb/serial/option.c > > +++ b/drivers/usb/serial/option.c > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = { > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) }, > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14), > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist > > - }, > > + }, > > Why not fix the same 'space' issue on the line before this at the same > time? And what about the remaining white-space issues in this file? Do we really want to go down this path? I could take a patch fixing them all at once (this time). It's you who'll have to deal with the changed contexts when back porting device ids, Greg. ;) Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/