Date: Wed, 22 Oct 2014 14:14:03 +0200
From: Petr Holasek <pholasek@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@intel.com>
Subject: Re: [RFC][PATCH] add pagesize field to /proc/pid/numa_maps
Message-ID: <20141022121403.GI2804@localhost.localdomain>
References: <1413847634-20039-1-git-send-email-pholasek@redhat.com>
 <alpine.DEB.2.02.1410201803540.2345@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1410201803540.2345@chino.kir.corp.google.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 20 Oct 2014, David Rientjes <rientjes@google.com> wrote:
> On Tue, 21 Oct 2014, Petr Holasek wrote:
> 
> > There were some similar attempts to add vma's pagesize to numa_maps in the past,
> > so I've distilled the most straightforward one - adding pagesize field
> > expressing size in kbytes to each line. Although page size can be also obtained
> > from smaps file, adding pagesize to numa_maps makes the interface more compact
> > and easier to use without need for traversing other files.
> > 
> > New numa_maps output looks like that:
> > 
> > 2aaaaac00000 default file=/dev/hugepages/hugepagefile huge pagesize=2097152 dirty=1 N0=1
> > 7f302441a000 default file=/usr/lib64/libc-2.17.so pagesize=4096 mapped=65 mapmax=38 N0=65
> > 
> > Signed-off-by: Petr Holasek <pholasek@redhat.com>
> 
> I guess the existing "huge" is insufficient on platforms that support 
> multiple hugepage sizes.

Why do you think so? pagesize= could also distinguish between multiple hugepage
sizes.

-- 
Petr Holasek
pholasek@redhat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/