Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbaJVOng (ORCPT ); Wed, 22 Oct 2014 10:43:36 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:57278 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbaJVOne (ORCPT ); Wed, 22 Oct 2014 10:43:34 -0400 X-Google-Original-Sender: Date: Wed, 22 Oct 2014 16:40:31 +0200 From: Johan Hovold To: Philip Munksgaard Cc: Greg KH , Johan Hovold , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: serial: Fix indentation style issue Message-ID: <20141022144031.GS2113@localhost> References: <1413035383-3981-1-git-send-email-pmunksgaard@gmail.com> <20141011142049.GA11456@kroah.com> <20141022095112.GJ2113@localhost> <20141022141857.GA8639@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 22, 2014 at 04:40:24PM +0200, Philip Munksgaard wrote: > On 22 October 2014 16:18, Greg KH wrote: > > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote: > >> On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: > >> > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > >> > > Fix a style issue > >> > > > >> > > Signed-off-by: Philip Munksgaard > >> > > --- > >> > > drivers/usb/serial/option.c | 2 +- > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > >> > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > >> > > index d1a3f60..d88998d 100644 > >> > > --- a/drivers/usb/serial/option.c > >> > > +++ b/drivers/usb/serial/option.c > >> > > @@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = { > >> > > { USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) }, > >> > > { USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14), > >> > > .driver_info = (kernel_ulong_t)&four_g_w14_blacklist > >> > > - }, > >> > > + }, > >> > > >> > Why not fix the same 'space' issue on the line before this at the same > >> > time? > >> > >> And what about the remaining white-space issues in this file? Do we > >> really want to go down this path? > > > > No, we don't, if you want to have patches be able to apply properly to > > older kernels, as you point out. > > > > Just don't add new whitespace issues please, that's all. > > I'm a bit confused. I've already submitted a new patch that merges the > two lines and fixes the whitespace issues on both (if you can't find > it, let me know and I'll resend it), is there anything else I'm > supposed to do? No, we're just not going to apply such fix-white-space patches, sorry. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/