Subject: [PATCH] remove error message on illegal ioctl
From: Robert Love <rml@tech9.net>
To: linux-kernel@vger.kernel.org
Content-Type: text/plain
Organization: 
Message-Id: <1039586157.4384.18.camel@phantasy>
Mime-Version: 1.0
Date: 11 Dec 2002 00:56:07 -0500
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 40

Linus is away so I am just throwing this out on lkml..

This error message is uber annoying and needs to go.  Non-root can flood
the console with this junk on invalid SCSI CD-ROM ioctl(), and that is
exactly what gnome-cd does.

An illegal ioctl() returns an error to the program.  That is sufficient
- we do not need KERN_ERROR warnings all over the place.  Especially
when any user can cause them at any rate.

This patch, against 2.5.51, removes the message.

	Robert Love

 drivers/scsi/sr_ioctl.c |    3 ---
 1 files changed, 3 deletions(-)


diff -urN linux-2.5.51-mm1/drivers/scsi/sr_ioctl.c linux/drivers/scsi/sr_ioctl.c
--- linux-2.5.51-mm1/drivers/scsi/sr_ioctl.c	2002-12-10 17:45:03.000000000 -0500
+++ linux/drivers/scsi/sr_ioctl.c	2002-12-11 00:44:24.000000000 -0500
@@ -156,9 +156,6 @@
 			err = -ENOMEDIUM;
 			break;
 		case ILLEGAL_REQUEST:
-			if (!cgc->quiet)
-				printk(KERN_ERR "%s: CDROM (ioctl) reports ILLEGAL "
-				       "REQUEST.\n", cd->cdi.name);
 			err = -EIO;
 			if (SRpnt->sr_sense_buffer[12] == 0x20 &&
 			    SRpnt->sr_sense_buffer[13] == 0x00)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/