Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbaJWGYK (ORCPT ); Thu, 23 Oct 2014 02:24:10 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:23417 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbaJWGYH (ORCPT ); Thu, 23 Oct 2014 02:24:07 -0400 Message-ID: <54489EDE.5070109@huawei.com> Date: Thu, 23 Oct 2014 14:23:26 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Bjorn Helgaas CC: , , Xinwei Hu , Wuyun , , Russell King , , , , , Arnd Bergmann , Thomas Gleixner , "Konrad Rzeszutek Wilk" , , Joerg Roedel , , , Benjamin Herrenschmidt , , , Sebastian Ott , "Tony Luck" , , "David S. Miller" , , Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , "Sergei Shtylyov" , Michael Ellerman , Thierry Reding , "Thomas Petazzoni" , Liviu Dudau Subject: Re: [PATCH v3 05/27] PCI: tegra: Save msi chip in pci_sys_data References: <1413342435-7876-1-git-send-email-wangyijing@huawei.com> <1413342435-7876-6-git-send-email-wangyijing@huawei.com> <20141023051831.GB11770@google.com> In-Reply-To: <20141023051831.GB11770@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014/10/23 13:18, Bjorn Helgaas wrote: > On Wed, Oct 15, 2014 at 11:06:53AM +0800, Yijing Wang wrote: >> Save msi chip in pci_sys_data instead of assign >> msi chip to every pci bus in .add_bus(). >> >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pci-tegra.c | 13 +++---------- >> 1 files changed, 3 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c >> index 3d43874..5af0525 100644 >> --- a/drivers/pci/host/pci-tegra.c >> +++ b/drivers/pci/host/pci-tegra.c >> @@ -694,15 +694,6 @@ static int tegra_pcie_map_irq(const struct pci_dev *pdev, u8 slot, u8 pin) >> return irq; >> } >> >> -static void tegra_pcie_add_bus(struct pci_bus *bus) >> -{ >> - if (IS_ENABLED(CONFIG_PCI_MSI)) { >> - struct tegra_pcie *pcie = sys_to_pcie(bus->sysdata); >> - >> - bus->msi = &pcie->msi.chip; >> - } >> -} >> - >> static struct pci_bus *tegra_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> { >> struct tegra_pcie *pcie = sys_to_pcie(sys); >> @@ -1881,11 +1872,13 @@ static int tegra_pcie_enable(struct tegra_pcie *pcie) >> >> memset(&hw, 0, sizeof(hw)); >> >> +#ifdef CONFIG_PCI_MSI >> + hw.msi_chip = &pcie->msi.chip; >> +#endif > > Why did you use "#ifdef CONFIG_PCI_MSI" instead of the > "IS_ENABLED(CONFIG_PCI_MSI)" used previously? Just personal habit. :) > > It's true that CONFIG_PCI_MSI will never be a tristate symbol, so we don't > really *need* the extra smarts of IS_ENABLED(), but I'm fairly sympathetic > to James' argument [1] that we should just use IS_ENABLED() all the time > because it's simpler overall. > > If you want to change the #ifdef to IS_ENABLED(), that should be a separate > patch from your msi_chip change, and we can debate the merits of that by > itself. > > [1] http://lkml.iu.edu//hypermail/linux/kernel/1204.3/00081.html Hi Bjorn, thanks for your guidance. I will use IS_ENABLED() instead of #ifdef for simplification in a separate patch. > >> hw.nr_controllers = 1; >> hw.private_data = (void **)&pcie; >> hw.setup = tegra_pcie_setup; >> hw.map_irq = tegra_pcie_map_irq; >> - hw.add_bus = tegra_pcie_add_bus; >> hw.scan = tegra_pcie_scan_bus; >> hw.ops = &tegra_pcie_ops; >> >> -- >> 1.7.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > . > -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/