Subject: [PATCH] epoll: don't printk pointer value
From: Robert Love <rml@tech9.net>
To: davidel@xmailserver.org
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain
Organization: 
Message-Id: <1039588045.833.3.camel@phantasy>
Mime-Version: 1.0
Date: 11 Dec 2002 01:27:25 -0500
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 37

Davide,

I really cannot think of a good reason why eventpoll_init() should print
a pointer value to user-space - especially the value of current?

I do not think this is good practice and someone might even consider it
a security hole.  Personally, I would prefer to remove the "successfully
initialized" message altogether, but at the very least can we not print
current's address?

	Robert Love


 fs/eventpoll.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff -urN linux-2.5.51/fs/eventpoll.c linux/fs/eventpoll.c
--- linux-2.5.51/fs/eventpoll.c	2002-12-09 21:45:54.000000000 -0500
+++ linux/fs/eventpoll.c	2002-12-11 01:23:07.000000000 -0500
@@ -1573,7 +1573,7 @@
 	if (IS_ERR(eventpoll_mnt))
 		goto eexit_4;
 
-	printk(KERN_INFO "[%p] eventpoll: successfully initialized.\n", current);
+	printk(KERN_INFO "eventpoll: successfully initialized.\n", current);
 
 	return 0;
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/