From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Chenhui Zhao <chenhui.zhao@freescale.com>, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de, leoli@freescale.com, Jason.Jin@freescale.com
Subject: Re: [PATCH v2 2/2] arm: pm: add deep sleep support for LS1
Date: Thu, 23 Oct 2014 09:52:13 +0200
Message-ID: <10927226.rVoqeXCnhH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1414037773-7735-2-git-send-email-chenhui.zhao@freescale.com>
References: <1414037773-7735-1-git-send-email-chenhui.zhao@freescale.com> <1414037773-7735-2-git-send-email-chenhui.zhao@freescale.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org

On Thursday 23 October 2014 12:16:13 Chenhui Zhao wrote:
> +extern void ls1_do_deepsleep(unsigned long addr);
> +extern void ls1_start_fsm(void);
> +extern void ls1_deepsleep_resume(void);
> +extern void ls1021a_set_secondary_entry(void);
> +extern int ls1_sram_code_size;
> +extern void fsl_epu_setup_default(void __iomem *epu_base);
> +

Please move these into a header file out of principle. I realize they
are defined in an assembly file, so the change won't actually add
any type safety as it would for functions defined in C files, but it's
better to be consistent.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/