Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbaJWIPG (ORCPT ); Thu, 23 Oct 2014 04:15:06 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:65026 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754115AbaJWIPB (ORCPT ); Thu, 23 Oct 2014 04:15:01 -0400 Date: Thu, 23 Oct 2014 12:14:57 +0400 From: Cyrill Gorcunov To: Arnd Bergmann Cc: Michael Ellerman , linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com, linux-api@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi Message-ID: <20141023081457.GE16267@moon> References: <1414040834-30209-1-git-send-email-mpe@ellerman.id.au> <2940943.qiYEMaLEXx@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2940943.qiYEMaLEXx@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote: > On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote: > > --- a/include/linux/kcmp.h > > +++ b/include/linux/kcmp.h > > @@ -1,17 +1,6 @@ > > #ifndef _LINUX_KCMP_H > > #define _LINUX_KCMP_H > > > > -/* Comparison type */ > > -enum kcmp_type { > > - KCMP_FILE, > > - KCMP_VM, > > - KCMP_FILES, > > - KCMP_FS, > > - KCMP_SIGHAND, > > - KCMP_IO, > > - KCMP_SYSVSEM, > > - > > - KCMP_TYPES, > > -}; > > +#include > > > > #endif /* _LINUX_KCMP_H */ > > > > If the file is empty except for the uapi include, I think it's better to > delete it completely. The include path logic should ensure we pick the > other one up. Good point, somehow managed to miss this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/