Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755709AbaJWMmd (ORCPT ); Thu, 23 Oct 2014 08:42:33 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:56673 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755680AbaJWMmb (ORCPT ); Thu, 23 Oct 2014 08:42:31 -0400 Date: Thu, 23 Oct 2014 07:42:43 -0500 From: Brian Vandre To: Lars-Peter Clausen Cc: Sudip Mukherjee , gregkh@linuxfoundation.org, jic23@kernel.org, alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org, marex@denx.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters Message-ID: <20141023124243.GA10433@brian-U> References: <20141022042115.GA2530@sudip-PC> <5448DD58.7030705@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5448DD58.7030705@metafoo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 23, 2014 at 12:50:00PM +0200, Lars-Peter Clausen wrote: > On 10/22/2014 06:21 AM, Sudip Mukherjee wrote: > >On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote: > >>This fixes the 2 checkpatch.pl warnings: > >>WARNING: line over 80 characters > >> > >please check your patch with --strict option of checkpatch.pl , and you will get : > >"Alignment should match open parenthesis" . > > Those checkpatch warnings are suggestions, not hard requirements. > The idea is to improve code legibility, but if the change has the > adverse effect the warning can and should be ignored. Also when > making a change you should keep the existing indention style of a > file. > > - Lars I think my patch does follow the style of the original file. If you run checkpatch.pl --strict on the whole file you will get many open parenthesis warnings. I believe it does make it slightly more legibile. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/