Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755989AbaJWNxD (ORCPT ); Thu, 23 Oct 2014 09:53:03 -0400 Received: from lists.s-osg.org ([54.187.51.154]:41765 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446AbaJWNw7 (ORCPT ); Thu, 23 Oct 2014 09:52:59 -0400 Message-ID: <54490832.7040906@osg.samsung.com> Date: Thu, 23 Oct 2014 07:52:50 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christopher Covington , Michael Ellerman CC: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton , gorcunov@openvz.org Subject: Re: [PATCH 3/3] selftests/kcmp: Always try to build the test References: <1414040834-30209-1-git-send-email-mpe@ellerman.id.au> <1414040834-30209-3-git-send-email-mpe@ellerman.id.au> <5448FD72.9040301@codeaurora.org> In-Reply-To: <5448FD72.9040301@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2014 07:06 AM, Christopher Covington wrote: > Hi Michael, > > On 10/23/2014 01:07 AM, Michael Ellerman wrote: >> Don't prevent the test building on non-x86. Just try and build it and >> let the chips fall where they may. > > As a user of kcmp via CRIU on arm and arm64, thanks! > >> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile >> index 4f00c0524501..cda9cc4004c9 100644 >> --- a/tools/testing/selftests/kcmp/Makefile >> +++ b/tools/testing/selftests/kcmp/Makefile >> @@ -1,21 +1,7 @@ >> -uname_M := $(shell uname -m 2>/dev/null || echo not) >> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) >> -ifeq ($(ARCH),i386) >> - ARCH := x86 >> - CFLAGS := -DCONFIG_X86_32 -D__i386__ >> -endif >> -ifeq ($(ARCH),x86_64) >> - ARCH := x86 >> - CFLAGS := -DCONFIG_X86_64 -D__x86_64__ >> -endif >> CFLAGS += -I../../../../usr/include/ >> >> all: >> -ifeq ($(ARCH),x86) >> gcc $(CFLAGS) kcmp_test.c -o kcmp_test > > Not that this needs to be addressed in this patch, but this looks broken for > cross compilation. It looks like some of the other selftests use: > > CC = $(CROSS_COMPILE)gcc > It makes sense to fix the cross-compile problem now, since this patch is extending the support to other archs. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/