Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754560AbaJWQZl (ORCPT ); Thu, 23 Oct 2014 12:25:41 -0400 Received: from mail-qg0-f43.google.com ([209.85.192.43]:50613 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752109AbaJWQZg (ORCPT ); Thu, 23 Oct 2014 12:25:36 -0400 MIME-Version: 1.0 In-Reply-To: <1414080959-6053-1-git-send-email-fabf@skynet.be> References: <1414080959-6053-1-git-send-email-fabf@skynet.be> Date: Thu, 23 Oct 2014 20:25:35 +0400 Message-ID: Subject: Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply() From: Ilya Dryomov To: Fabian Frederick Cc: Linux Kernel Mailing List , Sage Weil , "David S. Miller" , Ceph Development , netdev@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote: > osdmap_epoch is redundant with reassert_epoch and unused. > > Signed-off-by: Fabian Frederick > --- > net/ceph/osd_client.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index f3fc54e..432bd75 100644 > --- a/net/ceph/osd_client.c > +++ b/net/ceph/osd_client.c > @@ -1700,7 +1700,6 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg, > int err; > u32 reassert_epoch; > u64 reassert_version; > - u32 osdmap_epoch; > int already_completed; > u32 bytes; > unsigned int i; > @@ -1725,7 +1724,6 @@ static void handle_reply(struct ceph_osd_client *osdc, struct ceph_msg *msg, > result = ceph_decode_32(&p); > reassert_epoch = ceph_decode_32(&p); > reassert_version = ceph_decode_64(&p); > - osdmap_epoch = ceph_decode_32(&p); > > /* lookup */ > down_read(&osdc->map_sem); Hi Fabian, osdmap_epoch is useful for debugging, but this is wrong anyway - ceph_decode_32() has side effects. Removing it and not adjusting *p would make the whole thing blow up pretty fast.. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/