Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755470AbaJWS2K (ORCPT ); Thu, 23 Oct 2014 14:28:10 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:56178 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbaJWS2I convert rfc822-to-8bit (ORCPT ); Thu, 23 Oct 2014 14:28:08 -0400 From: Paul Zimmerman To: Bartlomiej Zolnierkiewicz , "dinguyen@opensource.altera.com" CC: "balbi@ti.com" , "dinh.linux@gmail.com" , "linux-kernel@vger.kernel.org" , "swarren@wwwdotorg.org" , "matthijs@stdin.nl" , "r.baldyga@samsung.com" , "jg1.han@samsung.com" , "sachin.kamat@linaro.org" , "ben-linux@fluff.org" , "dianders@chromium.org" , "kever.yang@rock-chips.com" , "linux-usb@vger.kernel.org" Subject: RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role Thread-Topic: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role Thread-Index: AQHP7JesnDFIW03SEUaNZEZCzxwRS5w8gsUAgAGAllA= Date: Thu, 23 Oct 2014 18:28:03 +0000 Message-ID: References: <1413831126-24193-1-git-send-email-dinguyen@opensource.altera.com> <1413831126-24193-8-git-send-email-dinguyen@opensource.altera.com> <9429092.fliZzSsbVp@amdc1032> In-Reply-To: <9429092.fliZzSsbVp@amdc1032> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.64.240] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@samsung.com] > Sent: Wednesday, October 22, 2014 5:26 AM > > On Monday, October 20, 2014 01:52:06 PM dinguyen@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > config USB_DWC2_PLATFORM > > bool "DWC2 Platform" > > - depends on USB_DWC2_HOST > > default USB_DWC2_HOST > > It should be "default USB_DWC2_HOST || USB_DWC2_PERIPHERAL" because > USB_DWC2_PLATFORM replaces current USB_DWC2_PERIPHERAL functionality. > > Additionaly USB_DWC2_PLATFORM should be changed to tristate > (USB_DWC2_PERIPHERAL was a tristeate before your changes). Dinh, I think this is a good point. Is there any reason why USB_DWC2_PLATFORM (and USB_DWC2_PCI for that matter) can't be tristate? That's what DWC3 does. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/