Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbaJWU3x (ORCPT ); Thu, 23 Oct 2014 16:29:53 -0400 Received: from mail.kernel.org ([198.145.19.201]:49284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932623AbaJWU3w (ORCPT ); Thu, 23 Oct 2014 16:29:52 -0400 Date: Thu, 23 Oct 2014 17:29:48 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , David Ahern , LKML , Hemant Kumar Subject: Re: [PATCH 4/5] perf tools: Add support for exclusive option Message-ID: <20141023202948.GK14687@kernel.org> References: <1413990949-13953-1-git-send-email-namhyung@kernel.org> <1413990949-13953-5-git-send-email-namhyung@kernel.org> <54488C84.3040408@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54488C84.3040408@hitachi.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Oct 23, 2014 at 02:05:08PM +0900, Masami Hiramatsu escreveu: > (2014/10/23 0:15), Namhyung Kim wrote: > > Some options cannot be used at the same time. To handle such options > > add a new PARSE_OPT_EXCLUSIVE flag and show error message if more than > > one of them is used. > > Looks useful for me :) > > Reviewed-by: Masami Hiramatsu > > I just have a comment below; > > > @@ -360,19 +378,21 @@ int parse_options_step(struct parse_opt_ctx_t *ctx, > > } > > > > if (arg[1] != '-') { > > - ctx->opt = arg + 1; > > + ctx->opt = ++arg; > > if (internal_help && *ctx->opt == 'h') > > return usage_with_options_internal(usagestr, options, 0); > > switch (parse_short_opt(ctx, options)) { > > case -1: > > - return parse_options_usage(usagestr, options, arg + 1, 1); > > + return parse_options_usage(usagestr, options, arg, 1); > > case -2: > > goto unknown; > > + case -3: > > + goto exclusive; > > BTW, it may be a time to define return error codes. Yeah, this thing looks unnecessarily complicated :-\ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/