Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755838AbaJXIAY (ORCPT ); Fri, 24 Oct 2014 04:00:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:6111 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbaJXIAX (ORCPT ); Fri, 24 Oct 2014 04:00:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,779,1406617200"; d="scan'208";a="610481880" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Robert Richter , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Stephane Eranian , Andi Kleen , kan.liang@intel.com, adrian.hunter@intel.com, acme@infradead.org Subject: Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver In-Reply-To: <20141022151413.GY12706@worktop.programming.kicks-ass.net> References: <1413207948-28202-1-git-send-email-alexander.shishkin@linux.intel.com> <1413207948-28202-13-git-send-email-alexander.shishkin@linux.intel.com> <20141022151413.GY12706@worktop.programming.kicks-ass.net> User-Agent: Notmuch/0.17+49~gaa57e9d (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Fri, 24 Oct 2014 10:59:56 +0300 Message-ID: <87wq7p28zn.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote: >> + if ((pt_cap_get(PT_CAP_topa_multiple_entries) >> + && topa->table[i].stop) >> + || topa->table[i].end) >> + break; > >> + old = (local64_xchg(&buf->head, base) & >> + ((buf->nr_pages << PAGE_SHIFT) - 1)); > >> + if (!pt_cap_get(PT_CAP_topa_multiple_entries) || >> + buf->output_off == sizes(TOPA_ENTRY(buf->cur, buf->cur_idx)->size)) { >> + local_inc(&buf->lost); >> + advance++; >> + } > > Inconsistent coding style. Please put operators at the end of a line, > not at the start of one. Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/