Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755452AbaJXITe (ORCPT ); Fri, 24 Oct 2014 04:19:34 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:48611 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbaJXITb (ORCPT ); Fri, 24 Oct 2014 04:19:31 -0400 MIME-Version: 1.0 In-Reply-To: <20141024081139.GA8861@thin> References: <1414114868-28228-1-git-send-email-ast@plumgrid.com> <20141024032355.GB7879@thin> <20141024081139.GA8861@thin> Date: Fri, 24 Oct 2014 10:19:29 +0200 X-Google-Sender-Auth: ZZSib38eMWloi9_xrSLQ-eA_DmU Message-ID: Subject: Re: [PATCH net] bpf: split eBPF out of NET From: Geert Uytterhoeven To: Josh Triplett Cc: Alexei Starovoitov , "David S. Miller" , Ingo Molnar , Steven Rostedt , Hannes Frederic Sowa , Eric Dumazet , Daniel Borkmann , Network Development , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 24, 2014 at 10:11 AM, Josh Triplett wrote: >> >> +config BPF_SYSCALL >> >> + bool "Enable bpf() system call" if EXPERT >> >> + select ANON_INODES >> >> + select BPF >> >> + default n >> >> + help >> >> + Enable the bpf() system call that allows to manipulate eBPF >> >> + programs and maps via file descriptors. >> > >> > Not sure this one goes under EXPERT, especially since it currently has >> > "default n". >> >> I followed the same style as EPOLL, EVENTFD and others >> in the same category. > > I was thinking of CROSS_MEMORY_ATTACH and FHANDLE in the same file. Those indeed look like better examples. With if EXPERT and default n, you need to enable EXPERT before you can enable the syscall, which is probably not what you want. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/