Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756058AbaJXJrN (ORCPT ); Fri, 24 Oct 2014 05:47:13 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:1749 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755262AbaJXJrJ (ORCPT ); Fri, 24 Oct 2014 05:47:09 -0400 Message-ID: <544A2017.7020804@imgtec.com> Date: Fri, 24 Oct 2014 10:47:03 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: Guenter Roeck , CC: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 08/47] kernel: Move pm_power_off to common code References: <1413864783-3271-1-git-send-email-linux@roeck-us.net> <1413864783-3271-9-git-send-email-linux@roeck-us.net> In-Reply-To: <1413864783-3271-9-git-send-email-linux@roeck-us.net> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guenter, On 21/10/14 05:12, Guenter Roeck wrote: > pm_power_off is defined for all architectures. Move it to common code. > > Have all architectures call do_kernel_power_off instead of pm_power_off. > Some architectures point pm_power_off to machine_power_off. For those, > call do_kernel_power_off from machine_power_off instead. > > Acked-by: David Vrabel > Acked-by: Geert Uytterhoeven > Acked-by: Hirokazu Takata > Acked-by: Jesper Nilsson > Acked-by: Max Filippov > Acked-by: Rafael J. Wysocki > Acked-by: Richard Weinberger > Acked-by: Xuetao Guan For metag: Acked-by: James Hogan Thanks James > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 483dff9..8d95773 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -67,9 +67,6 @@ void arch_cpu_idle_dead(void) > } > #endif > > -void (*pm_power_off)(void); > -EXPORT_SYMBOL(pm_power_off); > - > void (*soc_restart)(char *cmd); > void (*soc_halt)(void); > > @@ -90,8 +87,7 @@ void machine_halt(void) > > void machine_power_off(void) > { > - if (pm_power_off) > - pm_power_off(); > + do_kernel_power_off(); > smp_send_stop(); > hard_processor_halt(HALT_OK); > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/