Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbaJXJyM (ORCPT ); Fri, 24 Oct 2014 05:54:12 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:44663 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbaJXJyK (ORCPT ); Fri, 24 Oct 2014 05:54:10 -0400 From: Laurent Pinchart To: Joonsoo Kim Cc: Weijie Yang , Michal Nazarewicz , Laurent Pinchart , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, Marek Szyprowski , Russell King - ARM Linux Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated Date: Fri, 24 Oct 2014 12:54:08 +0300 Message-ID: <1796959.xTvOMRAxHJ@avalon> User-Agent: KMail/4.12.5 (Linux/3.14.14-gentoo; KDE/4.12.5; x86_64; ; ) In-Reply-To: <20141024025014.GA15243@js1304-P5Q-DELUXE> References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20141024025014.GA15243@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote: > On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote: > > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote: > > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: > > >> On Thu, Oct 23 2014, Laurent Pinchart wrote: > > >> > If activation of the CMA area fails its mutex won't be initialized, > > >> > leading to an oops at allocation time when trying to lock the mutex. > > >> > Fix this by failing allocation if the area hasn't been successfully > > >> > actived, and detect that condition by moving the CMA bitmap > > >> > allocation after page block reservation completion. > > >> > > > >> > Signed-off-by: Laurent Pinchart > > >> > > > >> > > >> Cc: # v3.17 > > >> Acked-by: Michal Nazarewicz > > > > This patch is good, but how about add a active field in cma struct? > > use cma->active to check whether cma is actived successfully. > > I think it will make code more clear and readable. > > Just my little opinion. > > Or just setting cma->count to 0 would work fine. I would prefer setting cma->count to 0 to avoid the extra field. I'll modify the patch accordingly. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/