Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756318AbaJXLvk (ORCPT ); Fri, 24 Oct 2014 07:51:40 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:40482 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756091AbaJXLvi (ORCPT ); Fri, 24 Oct 2014 07:51:38 -0400 Date: Fri, 24 Oct 2014 13:51:31 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Robert Richter , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Stephane Eranian , Andi Kleen , kan.liang@intel.com, adrian.hunter@intel.com, acme@infradead.org Subject: Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver Message-ID: <20141024115131.GY21513@worktop.programming.kicks-ass.net> References: <1413207948-28202-1-git-send-email-alexander.shishkin@linux.intel.com> <1413207948-28202-13-git-send-email-alexander.shishkin@linux.intel.com> <20141022144543.GV12706@worktop.programming.kicks-ass.net> <87tx2t27yb.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tx2t27yb.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 24, 2014 at 11:22:20AM +0300, Alexander Shishkin wrote: > > The fact that the hardware cannot even tell you the supported mask is > > further fail. > The problem with this is that some bits go in groups, there'd be 2..3..4 > bit fields encoding desired packet frequency, for example. OK, so put the magic number in the big model array. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/