Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756831AbaJXNoZ (ORCPT ); Fri, 24 Oct 2014 09:44:25 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:33329 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756639AbaJXNoW (ORCPT ); Fri, 24 Oct 2014 09:44:22 -0400 MIME-Version: 1.0 In-Reply-To: <544A5578.7030009@samsung.com> References: <1413775749-17539-1-git-send-email-cw00.choi@samsung.com> <1413775935-17743-5-git-send-email-cw00.choi@samsung.com> <544A5578.7030009@samsung.com> Date: Fri, 24 Oct 2014 07:44:21 -0600 Message-ID: Subject: Re: [PATCH 5/5] ARM: dts: Add dts files for Exynos4415 SoC From: Daniel Drake To: Marek Szyprowski Cc: Chanwoo Choi , linux-samsung-soc , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Kukjin Kim , ben-linux@fluff.org, Russell King , Mark Rutland , Arnd Bergmann , Olof Johansson , Tomasz Figa , Mike Turquette , thomas.abraham@linaro.org, Linus Walleij , Seung-Woo Kim , Kyungmin Park , InKi Dae , geunsik.lim@samsung.com, jh80.chung@samsung.com, jaewon02.kim@samsung.com, ideal.song@samsung.com, yj44.cho@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 24, 2014 at 7:34 AM, Marek Szyprowski wrote: > Well, I also thought about such approach, but there are some fundamental > differences: > interrupt and clock controllers are completely different. Using a common > exynos4.dtsi > and overriding them in every node will result in a code, which is a bit hard > to follow. > IMHO with such differences justifies using separate base dtsi file. For the things that aren't in common, they are already split out into soc-specific files for the existing Exynos4 variants. Taking your example of the CMU, it already differs in different exynos4 versions therefore is not listed in exynos4.dtsi at all. So this argument only seems valid if the differences are really huge, or if you are also saying the existing exynos4 dts files are bad? Personally I have come to like the current layout, although would definitely appreciate the reference-based syntax mentioned by Tomasz, and this seems like a good opportunity to at least fix up exynos4.dtsi for that. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/