Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbaJYDQQ (ORCPT ); Fri, 24 Oct 2014 23:16:16 -0400 Received: from static.92.5.9.176.clients.your-server.de ([176.9.5.92]:57458 "EHLO mail.hallyn.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbaJYDQN (ORCPT ); Fri, 24 Oct 2014 23:16:13 -0400 Date: Sat, 25 Oct 2014 05:16:08 +0200 From: "Serge E. Hallyn" To: Aditya Kali Cc: "Serge E. Hallyn" , Tejun Heo , Li Zefan , Serge Hallyn , Andy Lutomirski , cgroups@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux API , Ingo Molnar , Linux Containers Subject: Re: [PATCHv1 5/8] cgroup: introduce cgroup namespaces Message-ID: <20141025031608.GA13250@mail.hallyn.com> References: <1413235430-22944-1-git-send-email-adityakali@google.com> <1413235430-22944-6-git-send-email-adityakali@google.com> <20141016163703.GE1392@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Aditya Kali (adityakali@google.com): > >> +void free_cgroup_ns(struct cgroup_namespace *ns) > >> +{ > >> + cgroup_put(ns->root_cgrp); > >> + put_user_ns(ns->user_ns); > > > > This is a problem on error patch in copy_cgroup_ns. The > > alloc_cgroup_ns() doesn't initialize these values, so if > > you should fail in proc_alloc_inum() you'll show up here > > with fandom values in ns->*. > > > > I don't see the codepath that leads to calling free_cgroup_ns() with > uninitialized members. We don't call free_cgroup_ns() on the error > path in copy_cgroup_ns(). Hm, yeah, I'm not seeing it now, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/