Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbaJYSoM (ORCPT ); Sat, 25 Oct 2014 14:44:12 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:41346 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbaJYSoK (ORCPT ); Sat, 25 Oct 2014 14:44:10 -0400 X-IronPort-AV: E=Sophos;i="5.04,787,1406592000"; d="scan'208";a="186177149" Date: Sat, 25 Oct 2014 17:15:43 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Ian Campbell CC: Stefano Stabellini , Catalin Marinas , Will Deacon , "xen-devel@lists.xensource.com" , "konrad.wilk@oracle.com" , "david.vrabel@citrix.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux@arm.linux.org.uk" Subject: Re: [PATCH v4 3/7] [RFC] arm/arm64: introduce is_dma_coherent In-Reply-To: <1414251629.3584.20.camel@citrix.com> Message-ID: References: <1412941908-5850-3-git-send-email-stefano.stabellini@eu.citrix.com> <20141010120702.GI7755@arm.com> <20141013125725.GA19156@arm.com> <20141024104746.GC1955@localhost> <20141024154353.GE20534@e104818-lin.cambridge.arm.com> <1414251629.3584.20.camel@citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Oct 2014, Ian Campbell wrote: > On Sat, 2014-10-25 at 14:29 +0100, Stefano Stabellini wrote: > > > > Your suggestions and looking more at the code gave me another idea, that > > I think is clean and at the same time suitable for 3.18. > > What do you think of the following? It is simple, self-contained and > > doesn't need a new flag in struct device. > > of_dma_is_coherent looks to be quite expensive though (walks up the > Device Tree doing strcmps on each property of each node until it finds > the one it is looking for. It takes spin_locks too! Too bad, I think I'll have to ditch it. In that case I'l try the new flag in struct device approach. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/