Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbaJYTQJ (ORCPT ); Sat, 25 Oct 2014 15:16:09 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:50771 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbaJYTQH (ORCPT ); Sat, 25 Oct 2014 15:16:07 -0400 MIME-Version: 1.0 In-Reply-To: <1805780944.182558.1414228336940.open-xchange@webmail.nmp.skynet.be> References: <1414080959-6053-1-git-send-email-fabf@skynet.be> <1805780944.182558.1414228336940.open-xchange@webmail.nmp.skynet.be> Date: Sat, 25 Oct 2014 19:05:06 +0400 Message-ID: Subject: Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply() From: Ilya Dryomov To: Fabian Frederick Cc: netdev@vger.kernel.org, Linux Kernel Mailing List , Ceph Development , Sage Weil , "David S. Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 25, 2014 at 1:12 PM, Fabian Frederick wrote: > > >> On 23 October 2014 at 18:25 Ilya Dryomov wrote: >> >> >> On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote: >> > osdmap_epoch is redundant with reassert_epoch and unused. >> > >> > Signed-off-by: Fabian Frederick >> > --- >> > net/ceph/osd_client.c | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c >> > index f3fc54e..432bd75 100644 >> > --- a/net/ceph/osd_client.c >> > +++ b/net/ceph/osd_client.c >> > @@ -1700,7 +1700,6 @@ static void handle_reply(struct ceph_osd_client *osdc, >> > struct ceph_msg *msg, >> > int err; >> > u32 reassert_epoch; >> > u64 reassert_version; >> > - u32 osdmap_epoch; >> > int already_completed; >> > u32 bytes; >> > unsigned int i; >> > @@ -1725,7 +1724,6 @@ static void handle_reply(struct ceph_osd_client *osdc, >> > struct ceph_msg *msg, >> > result = ceph_decode_32(&p); >> > reassert_epoch = ceph_decode_32(&p); >> > reassert_version = ceph_decode_64(&p); >> > - osdmap_epoch = ceph_decode_32(&p); >> > >> > /* lookup */ >> > down_read(&osdc->map_sem); >> >> Hi Fabian, >> >> osdmap_epoch is useful for debugging, but this is wrong anyway - >> ceph_decode_32() has side effects. Removing it and not adjusting *p >> would make the whole thing blow up pretty fast.. >> >> Thanks, >> >> Ilya > > Hi Ilya, > > osdmap_epoch generates a warning with -Wunused-but-set-variable. > Maybe we could just do ceph_decode_32(&p) and remove it > (it doesn't seem to add a warning) and/or add some comment ? I see, I'll fix it up. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/