Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbaJYT6S (ORCPT ); Sat, 25 Oct 2014 15:58:18 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:51657 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbaJYT6P (ORCPT ); Sat, 25 Oct 2014 15:58:15 -0400 MIME-Version: 1.0 In-Reply-To: <544BFEDE.7050604@gmx.de> References: <1412858385-11954-1-git-send-email-daniel.baluta@intel.com> <1412858385-11954-2-git-send-email-daniel.baluta@intel.com> <544BF227.3030106@kernel.org> <544BFEDE.7050604@gmx.de> Date: Sat, 25 Oct 2014 22:58:14 +0300 X-Google-Sender-Auth: D0OlDM1qVvPZX9sF-I6U25un4A4 Message-ID: Subject: Re: [RFC PATCH v2 1/7] iio: dummy: Add virtual registers for dummy device From: Daniel Baluta To: Hartmut Knaack Cc: Jonathan Cameron , Daniel Baluta , irina.tirdea@intel.com, linux-iio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 25, 2014 at 10:49 PM, Hartmut Knaack wrote: > Jonathan Cameron schrieb am 25.10.2014 20:55: >> On 09/10/14 13:39, Daniel Baluta wrote: >>> We need a way to store events generated by iio_dummy_evgen module, >>> in order to correctly process IRQs in iio_simple_dummy_events. >>> >>> For the moment, we add two registers: >>> >>> * id_reg - ID register, stores the source of the event >>> * id_data - DATA register, stores the type of the event >>> >>> e.g echo 4 > /sys/bus/iio/devices/iio_evgen/poke2 >>> >>> id_reg 0x02, id_data 0x04 >>> >>> This means, event of type 4 was generated by fake device 2. >>> >>> We currently use a hardcoded mapping of virtual events to IIO events. >>> >>> Signed-off-by: Irina Tirdea >>> Signed-off-by: Daniel Baluta >> Applied to the togreg branch of iio.git. >> Initially pushed out as testing for the autobuilders to play with it. > I think Daniel wanted to work on a V3 for (at least) this one, fixing variable type of ret from long to int in iio_evgen_poke(). Had spotted it in V1, when V2 was already sent out - sorry for that. See [1]. Correct, I was just waiting on feedback for other patches. I will send v3 as soon as possible. thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/