Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbaJ0NSh (ORCPT ); Mon, 27 Oct 2014 09:18:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51954 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752758AbaJ0NSd (ORCPT ); Mon, 27 Oct 2014 09:18:33 -0400 Date: Mon, 27 Oct 2014 14:18:31 +0100 From: David Sterba To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH 09/11] tty: ipwireless: Fix probable mask then right shift defects Message-ID: <20141027131831.GE22943@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Joe Perches , linux-kernel@vger.kernel.org, Jiri Kosina , Greg Kroah-Hartman , Jiri Slaby References: <5f61fec0dbc7d50715800c94b19db5914b1af610.1414387334.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f61fec0dbc7d50715800c94b19db5914b1af610.1414387334.git.joe@perches.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 26, 2014 at 10:25:05PM -0700, Joe Perches wrote: > Precedence of & and >> is not the same and is not left to right. > shift has higher precedence and should be done after the mask. > > Add parentheses around the masks. > > Signed-off-by: Joe Perches Acked-by: David Sterba Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/