Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753020AbaJ0Nib (ORCPT ); Mon, 27 Oct 2014 09:38:31 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:35600 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbaJ0Ni3 convert rfc822-to-8bit (ORCPT ); Mon, 27 Oct 2014 09:38:29 -0400 MIME-Version: 1.0 In-Reply-To: <1413883364-681-2-git-send-email-sebastian.hesselbarth@gmail.com> References: <1413883364-681-1-git-send-email-sebastian.hesselbarth@gmail.com> <1413883364-681-2-git-send-email-sebastian.hesselbarth@gmail.com> Date: Mon, 27 Oct 2014 14:38:28 +0100 Message-ID: Subject: Re: [PATCH RESEND 01/12] mmc: sdhci-pxav2: Drop unused struct sdhci_pxa From: Ulf Hansson To: Sebastian Hesselbarth Cc: Chris Ball , =?UTF-8?Q?Antoine_T=C3=A9nart?= , linux-mmc , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 October 2014 11:22, Sebastian Hesselbarth wrote: > struct sdhci_pxa is private data of PXA SDHCI driver, but not used in > sdhci-pxav2 at all. Drop unused references to struct sdhci_pxa. > > Signed-off-by: Sebastian Hesselbarth Thanks! Applied for next! Kind regards Uffe > --- > Cc: Chris Ball > Cc: Ulf Hansson > Cc: "Antoine Ténart" > Cc: linux-mmc@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/mmc/host/sdhci-pxav2.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c > index b4c23e983baf..f98008b5ea77 100644 > --- a/drivers/mmc/host/sdhci-pxav2.c > +++ b/drivers/mmc/host/sdhci-pxav2.c > @@ -167,23 +167,17 @@ static int sdhci_pxav2_probe(struct platform_device *pdev) > struct sdhci_pxa_platdata *pdata = pdev->dev.platform_data; > struct device *dev = &pdev->dev; > struct sdhci_host *host = NULL; > - struct sdhci_pxa *pxa = NULL; > const struct of_device_id *match; > > int ret; > struct clk *clk; > > - pxa = kzalloc(sizeof(struct sdhci_pxa), GFP_KERNEL); > - if (!pxa) > - return -ENOMEM; > - > host = sdhci_pltfm_init(pdev, NULL, 0); > - if (IS_ERR(host)) { > - kfree(pxa); > + if (IS_ERR(host)) > return PTR_ERR(host); > - } > + > pltfm_host = sdhci_priv(host); > - pltfm_host->priv = pxa; > + pltfm_host->priv = NULL; > > clk = clk_get(dev, "PXA-SDHCLK"); > if (IS_ERR(clk)) { > @@ -238,7 +232,6 @@ err_add_host: > clk_put(clk); > err_clk_get: > sdhci_pltfm_free(pdev); > - kfree(pxa); > return ret; > } > > @@ -246,14 +239,12 @@ static int sdhci_pxav2_remove(struct platform_device *pdev) > { > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct sdhci_pxa *pxa = pltfm_host->priv; > > sdhci_remove_host(host, 1); > > clk_disable_unprepare(pltfm_host->clk); > clk_put(pltfm_host->clk); > sdhci_pltfm_free(pdev); > - kfree(pxa); > > return 0; > } > -- > 2.1.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/