Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbaJ0Po4 (ORCPT ); Mon, 27 Oct 2014 11:44:56 -0400 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:49117 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbaJ0Poy (ORCPT ); Mon, 27 Oct 2014 11:44:54 -0400 Date: Mon, 27 Oct 2014 15:44:46 +0000 From: Lorenzo Pieralisi To: Will Deacon Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Liviu Dudau , "suravee.suthikulpanit@amd.com" , Arnd Bergmann , Bjorn Helgaas Subject: Re: [PATCH RFC 2/2] drivers: pci: convert generic host controller to DT resource parsing API Message-ID: <20141027154446.GA773@red-moon> References: <1414077787-20633-1-git-send-email-lorenzo.pieralisi@arm.com> <1414077787-20633-2-git-send-email-lorenzo.pieralisi@arm.com> <20141027120335.GQ8768@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141027120335.GQ8768@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 27, 2014 at 12:03:35PM +0000, Will Deacon wrote: > On Thu, Oct 23, 2014 at 04:23:07PM +0100, Lorenzo Pieralisi wrote: > > In order to consolidate DT configuration for PCI host controllers in the > > kernel, a new API (ie of_pci_get_host_bridge_resources()) was developed > > to allow parsing and assigning IO/BUS/MEM resources from DT, removing > > duplicated code present in the majority of pci host driver implementations. > > > > This patch converts the existing PCI generic host controller driver to > > the new API. Most of the code parsing ranges and creating resources is > > now delegated to of_pci_get_host_bridge_resources() API. > > > > The PCI host controller code carries out resources filtering on the > > resulting resource list and maps IO space by using the newly introduced > > pci_ioremap_iospace() API. > > > > New code supports only one IO resource per generic host controller, which > > should cater for all existing host controller configurations. > > > > Cc: Arnd Bergmann > > Cc: Will Deacon > > Cc: Bjorn Helgaas > > Signed-off-by: Lorenzo Pieralisi > > --- > > drivers/pci/host/pci-host-generic.c | 120 ++++++++---------------------------- > > 1 file changed, 27 insertions(+), 93 deletions(-) > > Looks fine to me -- I assume you tested this under a 32-bit kernel? Yes, through kvmtools, 32-bit guest on 32/64 bits hosts. I will keep on testing it before asking to merge it in -next. I would be grateful if the parsing logic could be tested on arm64 too (Suravee, did you give them a try ?) and collect the resulting tested-by. > Acked-by: Will Deacon Thank you ! Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/