Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbaJ0P7G (ORCPT ); Mon, 27 Oct 2014 11:59:06 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:35338 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713AbaJ0P7B convert rfc822-to-8bit (ORCPT ); Mon, 27 Oct 2014 11:59:01 -0400 MIME-Version: 1.0 In-Reply-To: <1413864783-3271-13-git-send-email-linux@roeck-us.net> References: <1413864783-3271-1-git-send-email-linux@roeck-us.net> <1413864783-3271-13-git-send-email-linux@roeck-us.net> Date: Mon, 27 Oct 2014 16:59:00 +0100 Message-ID: Subject: Re: [PATCH v2 12/47] mfd: ab8500-sysctrl: Register with kernel poweroff handler From: Linus Walleij To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , Lee Jones , Samuel Ortiz , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 21, 2014 at 6:12 AM, Guenter Roeck wrote: > Register with kernel poweroff handler instead of setting pm_power_off > directly. Register with low priority to reflect that the original code > only sets pm_power_off if it was not already set. > > sysctrl_dev is set prior to poweroff handler registration, and the > poweroff handler is unregistered prior to clearing sysrctrl_dev. > It is therefore not necessary to check if sysctrl_dev is NULL in the > poweroff handler, and the check was removed. Setting sysctrl_dev to NULL > in the remove function was also removed as unnecessary. With those changes, > devm_register_power_off_handler can be used to register the poeroff handler. > The now empty remove function was retained since the ab8500_restart function, > which is currently unused, would likely need some cleanup if it was ever used. > > Cc: Linus Walleij > Cc: Lee Jones > Cc: Samuel Ortiz > Signed-off-by: Guenter Roeck > --- > v2: > - Use define to specify poweroff handler priority > - Use devm_register_power_off_handler > - Use dev_warn instead of dev_err > - Since we use devm_register_power_off_handler, > we need to check if sysctrl_dev in the poweroff handler to avoid > a race condition on unload, so this check is no longer removed I can't compile this, I guess because of a dependency on some other patch? CC drivers/mfd/ab8500-sysctrl.o ../drivers/mfd/ab8500-sysctrl.c:94:14: error: ‘POWEROFF_PRIORITY_LOW’ undeclared here (not in a function) .priority = POWEROFF_PRIORITY_LOW, ^ ../drivers/mfd/ab8500-sysctrl.c: In function ‘ab8500_sysctrl_probe’: ../drivers/mfd/ab8500-sysctrl.c:206:2: error: implicit declaration of function ‘devm_register_power_off_handler’ [-Werror=implicit-function-declaration] err = devm_register_power_off_handler(sysctrl_dev, &ab8500_poweroff_nb); I wanted to provide a Tested-by but I guess I can only give this: Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/