Message-ID: <1414426831.20978.4.camel@mm-sol.com>
Subject: Re: [PATCH 2/4] Input: pmic8xxx-keypad - use regmap_field for
 register access
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Stephen Boyd <sboyd@codeaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@sonymobile.com>
Date: Mon, 27 Oct 2014 18:20:31 +0200
In-Reply-To: <20141027160641.GB7594@dtor-ws>
References: <20141007172606.GG16469@dtor-ws>
	 <1412759584.13569.0.camel@iivanov-dev>
	 <1412760633.13569.4.camel@iivanov-dev> <54357BA7.3010609@codeaurora.org>
	 <20141008181314.GC14423@dtor-ws> <5435808A.7070203@codeaurora.org>
	 <20141008200426.GJ4609@sirena.org.uk> <20141008203233.GA15198@dtor-ws>
	 <20141013140218.GG27755@sirena.org.uk>
	 <1414423841.20978.1.camel@mm-sol.com> <20141027160641.GB7594@dtor-ws>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org


On Mon, 2014-10-27 at 09:06 -0700, Dmitry Torokhov wrote:
> On Mon, Oct 27, 2014 at 05:30:41PM +0200, Ivan T. Ivanov wrote:
> > Hi Dmitry,
> > 
> > On Mon, 2014-10-13 at 16:02 +0200, Mark Brown wrote:
> > > On Wed, Oct 08, 2014 at 01:32:33PM -0700, Dmitry Torokhov wrote:
> > > > On Wed, Oct 08, 2014 at 09:04:26PM +0100, Mark Brown wrote:
> > > > > On Wed, Oct 08, 2014 at 11:20:58AM -0700, Stephen Boyd wrote:
> > > 
> > > > > > Srini/Mark, any reason why the regmap_field structure is opaque?
> > > 
> > > > > So you can't peer into it and rely on the contents.  I can see it being
> > > > > useful to add a bulk allocator.
> > > 
> > > > And then one have to define offsets in an array and use awkward syntax
> > > > to access individual fields. Can we just reply on reviews/documentation
> > > > for users to not do wrong thing?
> > > 
> > > I have very little confidence in users not doing awful things to be
> > > honest, this is the sort of API where the users are just random things
> > > all over the kernel so this sort of thing tends to be found after the
> > > fact.  I get a lot of these in drivers that just got thrown over the
> > > wall so nobody really knows what things are doing when you do find them.
> > > 
> > > If the standard allocators aren't doing a good job (I've not checked)
> > > I'd much rather handle this inside the API if we can.
> > > 
> > 
> > Is there something that I can help here or patches are good as they are? :-)
> 
> Well, as far as I can see Bjorn (in the other thread) has some
> objections on merging these devices together, so I ma just waiting for
> you settle this issue.

In the other thread we are discussing "pm8xxx-pwrkey" driver not this 
"pm8xxx-keypad" driver. Unless I not missing something? 


Regards,
Ivan

> 
> I see he's not on this therad so let's CC him.
> 
> For the record I ma still not happy that we need to dynamically allocate
> all these regmap fields.
> 
> Thanks.
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/