Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbaJ0Qqw (ORCPT ); Mon, 27 Oct 2014 12:46:52 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:34833 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbaJ0Qqt (ORCPT ); Mon, 27 Oct 2014 12:46:49 -0400 Date: Mon, 27 Oct 2014 17:43:38 +0100 From: Johan Hovold To: Felipe Balbi Cc: Lucas Stach , Romain Perier , heiko@sntech.de, devicetree@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, grant.likely@linaro.org, robh@kernel.org, mark.rutland@arm.com, johan@kernel.org, linux-pm@vger.kernel.org, linux@roeck-us.net, lee.jones@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 06/10] mfd: tps65910: Use the standard DT property system-power-controller Message-ID: <20141027164338.GE2006@localhost> References: <1414427215-14380-1-git-send-email-romain.perier@gmail.com> <1414427215-14380-6-git-send-email-romain.perier@gmail.com> <1414427749.2421.5.camel@pengutronix.de> <20141027164153.GE14253@saruman> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141027164153.GE14253@saruman> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 27, 2014 at 11:41:53AM -0500, Felipe Balbi wrote: > On Mon, Oct 27, 2014 at 05:35:49PM +0100, Lucas Stach wrote: > > Am Montag, den 27.10.2014, 16:26 +0000 schrieb Romain Perier: > > > No longer use custom property to define poweroff capability, use the standard > > > DT property instead. > > > > > > Signed-off-by: Romain Perier > > > --- > > > drivers/mfd/tps65910.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c > > > index 7612d89..a7faff2 100644 > > > --- a/drivers/mfd/tps65910.c > > > +++ b/drivers/mfd/tps65910.c > > > @@ -423,8 +423,7 @@ static struct tps65910_board *tps65910_parse_dt(struct i2c_client *client, > > > > > > board_info->irq = client->irq; > > > board_info->irq_base = -1; > > > - board_info->pm_off = of_property_read_bool(np, > > > - "ti,system-power-controller"); > > > + board_info->pm_off = of_is_system_power_controller(); > > > > > > return board_info; > > > } > > You are breaking compatibility with older DTs here. This is not > > acceptable. > > > > You may change all in-tree DTs to use the new property and also patch > > the driver to understand it, but you must make sure that the driver > > still understands the old, custom property. And especially in this case > > it isn't really hard to do. > > correct, it should be simple to hide that under > of_is_system_power_controller() itself. Guys, take a look at the code (PATCH 1/10). ;) Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/