Message-ID: <544E99A4.4020906@amd.com>
Date: Mon, 27 Oct 2014 14:14:44 -0500
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>
CC: <mark.rutland@arm.com>, <will.deacon@arm.com>, <catalin.marinas@arm.com>,
        Thomas Lendacky <Thomas.Lendacky@amd.com>,
        Joel Schopp <Joel.Schopp@amd.com>, <marc.zyngier@arm.com>,
        <liviu.dudau@arm.com>, <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH V2] arm64: amd-seattle: Adding device tree for AMD Seattle
 platform
References: <1414436065-7717-1-git-send-email-suravee.suthikulpanit@amd.com>
 <2202046.Qx9l5PJfzL@wuerfel>
In-Reply-To: <2202046.Qx9l5PJfzL@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 10/27/2014 2:07 PM, Arnd Bergmann wrote:
> On Monday 27 October 2014 13:54:25 suravee.suthikulpanit@amd.com wrote:
>> +       sata0: sata@00300000 {
>> +               compatible = "snps,spear-ahci";
>> +               reg = <0 0x300000 0 0x800>;
>> +               interrupts = <0 355 4>;
>> +               clocks = <&sataclk_333mhz>;
>> +               clock-names = "apb_pclk";
>> +               dma-coherent;
>> +       };
>
> Please use "snps,dwc-ahci" as the compatible string for a designware
> ahci controller, not "snps,spear-ahci", which refers to the implementation
> of that in the ST microelectronics SPEAr consumer SoC.
>
> It would be good to also add a string that is specific for your SoC if
> we ever need to identify it directly.
>
> 	Arnd
>

Thanks. I will update this in V3.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/