Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbaJ0WvV (ORCPT ); Mon, 27 Oct 2014 18:51:21 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:55300 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751953AbaJ0WvT (ORCPT ); Mon, 27 Oct 2014 18:51:19 -0400 From: "Rafael J. Wysocki" To: Bjorn Helgaas Cc: Jiang Liu , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Len Brown , Konrad Rzeszutek Wilk , Andrew Morton , Tony Luck , Joerg Roedel , Greg Kroah-Hartman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [Patch v7 05/18] ACPI: Correct return value of acpi_dev_resource_address_space() Date: Tue, 28 Oct 2014 00:11:53 +0100 Message-ID: <2637527.N3qngMM9sh@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1414387308-27148-1-git-send-email-jiang.liu@linux.intel.com> <1414387308-27148-6-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 27, 2014 04:49:06 PM Bjorn Helgaas wrote: > On Sun, Oct 26, 2014 at 11:21 PM, Jiang Liu wrote: > > Change acpi_dev_resource_address_space() to return failure if the > > acpi_resource structure can't be converted to an ACPI address64 > > structure, so caller could correctly detect failure. > > Fixes: 046d9ce6820e ("ACPI: Move device resources interpretation code > from PNP to ACPI core") > > Possible stable candidate? 046d9ce6820e appeared in v3.8. Well, are we seeing problems with it? > > Signed-off-by: Jiang Liu > > --- > > drivers/acpi/resource.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > > index 2ba8f02ced36..782a0d15c25f 100644 > > --- a/drivers/acpi/resource.c > > +++ b/drivers/acpi/resource.c > > @@ -200,7 +200,7 @@ bool acpi_dev_resource_address_space(struct acpi_resource *ares, > > > > status = acpi_resource_to_address64(ares, &addr); > > if (ACPI_FAILURE(status)) > > - return true; > > + return false; > > > > res->start = addr.minimum; > > res->end = addr.maximum; > > -- > > 1.7.10.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/