Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757539AbaJ1GA0 (ORCPT ); Tue, 28 Oct 2014 02:00:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:62445 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbaJ1GAX (ORCPT ); Tue, 28 Oct 2014 02:00:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="407084852" Message-ID: <544F303C.10903@intel.com> Date: Tue, 28 Oct 2014 13:57:16 +0800 From: Ren Qiaowei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Thomas Gleixner CC: "H. Peter Anvin" , Ingo Molnar , "Hansen, Dave" , "x86@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@linux-mips.org" Subject: Re: [PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMENT References: <1413088915-13428-1-git-send-email-qiaowei.ren@intel.com> <1413088915-13428-11-git-send-email-qiaowei.ren@intel.com> <9E0BE1322F2F2246BD820DA9FC397ADE0180ED65@shsmsx102.ccr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2014 04:38 AM, Thomas Gleixner wrote: > On Mon, 27 Oct 2014, Ren, Qiaowei wrote: >> On 2014-10-24, Thomas Gleixner wrote: >>> On Sun, 12 Oct 2014, Qiaowei Ren wrote: >>>> +int mpx_enable_management(struct task_struct *tsk) { >>>> + struct mm_struct *mm = tsk->mm; >>>> + void __user *bd_base = MPX_INVALID_BOUNDS_DIR; >>> >>> What's the point of initializing bd_base here. I had to look twice to >>> figure out that it gets overwritten by task_get_bounds_dir() >>> >> >> I just want to put task_get_bounds_dir() outside mm->mmap_sem holding. > > What you want is not interesting at all. What's interesting is what > you do and what you send for review. > I see. Thanks. - Qiaowei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/