Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759204AbaJ1HZ7 (ORCPT ); Tue, 28 Oct 2014 03:25:59 -0400 Received: from mail-qa0-f52.google.com ([209.85.216.52]:41519 "EHLO mail-qa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759179AbaJ1HZ4 (ORCPT ); Tue, 28 Oct 2014 03:25:56 -0400 MIME-Version: 1.0 In-Reply-To: <20141027175725.GB18557@sirena.org.uk> References: <1414427215-14380-1-git-send-email-romain.perier@gmail.com> <1414427215-14380-2-git-send-email-romain.perier@gmail.com> <20141027163918.GB14253@saruman> <20141027172636.GZ18557@sirena.org.uk> <20141027173025.GA16005@saruman> <20141027175725.GB18557@sirena.org.uk> Date: Tue, 28 Oct 2014 08:25:55 +0100 Message-ID: Subject: Re: [PATCH v1 02/10] dt-bindings: Document the standard property "system-power-controller" From: Romain Perier To: Mark Brown Cc: Felipe Balbi , =?UTF-8?Q?Heiko_St=C3=BCbner?= , devicetree , Liam Girdwood , Linux Kernel Mailing List , Grant Likely , robh , Mark Rutland , Johan Hovold , "linux-pm@vger.kernel.org" , Guenter Roeck , Lee Jones , Rob Herring , "pawel.moll" , "ijc+devicetree" , Kumar Gala , Russell King - ARM Linux , Stephen Warren , Thierry Reding , Alexandre Courbot , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If this is possible, that's probably better to drop all these patches (including poweroff-source) from "next", in this way it will be possible to re-do things properly from scratch (with the new name). If you have a look at linux-next the property "poweroff-source" is already used by tps910 AND act8865, I don't like that (it is not used yet by dts files). I mean, I don't really want to support "vendor,system-power-controller", "system-power-controller" and "poweroff-source" from "of_has_system_power_source" and do a lot of unclean commits in order to don't break compatibility. Just keep things simple. What do you think ? 2014-10-27 18:57 GMT+01:00 Mark Brown : > On Mon, Oct 27, 2014 at 12:30:25PM -0500, Felipe Balbi wrote: >> On Mon, Oct 27, 2014 at 05:26:36PM +0000, Mark Brown wrote: > >> > Given that poweroff-source hasn't made it into a released kernel yet we >> > can probably just kill it off completely can't we? > >> please do, then we will never have that commit in Linus' tree to give us >> nightmares. > > Well, the commit isn't a particularly big deal (and got cross-merged > into another tree already) - if it's convenient to rebase it out we > probably should but it's also not the end of the world either so long as > it doesn't appear in a release. Worst case people adopt it based on the > list discussions and we check for two properties which also isn't that > bad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/